From 350c27c8b441ea73a3c5bf45500659da364f090c Mon Sep 17 00:00:00 2001 From: Hugo Date: Thu, 14 Nov 2019 11:36:47 +0200 Subject: [PATCH 1/2] Update text in PR template --- .github/PULL_REQUEST_TEMPLATE.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f516959bc83..843b67294b7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,7 +2,6 @@ Thanks for submitting a PR, your contribution is really appreciated! Here is a quick checklist that should be present in PRs. -(please delete this text from the final description, this is just a guideline) --> - [ ] Target the `master` branch for bug fixes, documentation updates and trivial changes. @@ -10,7 +9,7 @@ Here is a quick checklist that should be present in PRs. - [ ] Include documentation when adding new features. - [ ] Include new tests or update existing tests when applicable. -Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please: +Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please: - [ ] Create a new changelog file in the `changelog` folder, with a name like `..rst`. See [changelog/README.rst](https://github.com/pytest-dev/pytest/blob/master/changelog/README.rst) for details. -- [ ] Add yourself to `AUTHORS` in alphabetical order; +- [ ] Add yourself to `AUTHORS` in alphabetical order. From 48ec7d28c6485da6dc220cd9a5acdbcfc6615ff1 Mon Sep 17 00:00:00 2001 From: Hugo Date: Thu, 14 Nov 2019 12:01:40 +0200 Subject: [PATCH 2/2] Make whole checklist a comment to avoid incomplete TODOs in PRs --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 843b67294b7..7436f714625 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,7 +2,6 @@ Thanks for submitting a PR, your contribution is really appreciated! Here is a quick checklist that should be present in PRs. ---> - [ ] Target the `master` branch for bug fixes, documentation updates and trivial changes. - [ ] Target the `features` branch for new features, improvements, and removals/deprecations. @@ -13,3 +12,4 @@ Unless your change is trivial or a small documentation fix (e.g., a typo or rewo - [ ] Create a new changelog file in the `changelog` folder, with a name like `..rst`. See [changelog/README.rst](https://github.com/pytest-dev/pytest/blob/master/changelog/README.rst) for details. - [ ] Add yourself to `AUTHORS` in alphabetical order. +-->