Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockAwareDocTestFinder._find is stale #12432

Closed
jaraco opened this issue Jun 6, 2024 · 0 comments · Fixed by #12431
Closed

MockAwareDocTestFinder._find is stale #12432

jaraco opened this issue Jun 6, 2024 · 0 comments · Fixed by #12431
Assignees

Comments

@jaraco
Copy link
Contributor

jaraco commented Jun 6, 2024

The implementation of _find has no comments:

def _find(
self, tests, obj, name, module, source_lines, globs, seen
) -> None:
if _is_mocked(obj):
return
with _patch_unwrap_mock_aware():
# Type ignored because this is a private function.
super()._find( # type:ignore[misc]
tests, obj, name, module, source_lines, globs, seen
)

Perhaps the comments in the class are related. Indeed, looking at where that method was introduced (a6988aa), it's associated with the docstring in the class.

It appears that the tests all pass with the method removed on Python 3.10 and later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant