New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deselection incorrectly determines the deselection reason #1372

Closed
RonnyPfannschmidt opened this Issue Feb 10, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@RonnyPfannschmidt
Member

RonnyPfannschmidt commented Feb 10, 2016

the combination of the terminal plugin and the mark plugin assume, only the mark plugin can deselect tests

so that's whats being used in the terminal summary, and the hook for Deselection does not consider getting a deselection Reason

i propose adding a deselection reason too the hook and requiring plugins that deselect to pass it
starting in 3.0

in order to support that we might need to add support for defaults to hook invocation and specification in pluggy

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Aug 2, 2016

Fixed in #1779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment