New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.0/3.1/3.2/2.6? #1627

Closed
The-Compiler opened this Issue Jun 21, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@The-Compiler
Member

The-Compiler commented Jun 21, 2016

After talking to some people at the sprint I'd like to propose dropping older Python versions in pytest 3.0.

In other issues we commonly told people we'll drop things when pip does, so we could safely drop 3.0/3.1/3.2 with pytest 3.0.

Looking at pypa/pip#3796 3.2 usage on PyPI is 0.03% (pip8) or 0.08% (earlier pip versions), so I think we should drop <= 3.2. Other testing related tools like coverage.py and various pytest plugins did so as well already.

As for 2.6, it's more commonly used, and still what people on e.g. CentOS are stuck with, so I'd rather not drop it before pip does (also because that's kind of what we promised to various people).

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Jun 21, 2016

Regarding Python 3: we already only support 3.3 onwards, if I'm not mistaken. Actually, on tox we only test 3.3 onwards, but our setup.py still declares 3.2 support, so we should fix that.

About Python 2.6, I agree.

@The-Compiler

This comment has been minimized.

Member

The-Compiler commented Jun 21, 2016

We should also make sure to adjust the docs accordingly - for example, pytest.org still says "Python 2.6-3.5" which IMHO includes 3.0-3.3.

@RonnyPfannschmidt

This comment has been minimized.

Member

RonnyPfannschmidt commented Jun 21, 2016

We also have strange support code around

@RonnyPfannschmidt RonnyPfannschmidt self-assigned this Jun 27, 2016

RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Jun 27, 2016

RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this issue Jun 27, 2016

@The-Compiler

This comment has been minimized.

Member

The-Compiler commented Jun 30, 2016

@RonnyPfannschmidt should this be closed or is there still code left we can get rid of before dropping 2.6?

@RonnyPfannschmidt

This comment has been minimized.

Member

RonnyPfannschmidt commented Jun 30, 2016

there is code for python 2.4 assert statement range, that in part relates to a python 2.5/2.6 issue as well,
atm i suggest keeping until python 2.6 removal

@The-Compiler

This comment has been minimized.

Member

The-Compiler commented Aug 5, 2016

Closing this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment