Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce six to the codebase to deal with Python 2/Python 3 differences #2642

Closed
nicoddemus opened this Issue Aug 1, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@nicoddemus
Copy link
Member

nicoddemus commented Aug 1, 2017

It would be nice to remove a good portion of our Python 2/Python 3 own compatibility layer. Ultimately we must see if the change is worthwhile (my initial feeling is that it is, but that is to be seen yet).

@RonnyPfannschmidt

This comment has been minimized.

Copy link
Member

RonnyPfannschmidt commented Aug 1, 2017

this also would remove a lot of the messy pylib dependencies

@nicoddemus

This comment has been minimized.

Copy link
Member Author

nicoddemus commented Aug 2, 2017

Realized that we should discuss if six should be vendored or not, given that six also tests itself using pytest, similar to the discussion taking place in #2641. I guess the exact same arguments to vendor attrs or not apply to six.

@RonnyPfannschmidt

This comment has been minimized.

Copy link
Member

RonnyPfannschmidt commented Aug 3, 2017

important point -

@nicoddemus

This comment has been minimized.

Copy link
Member Author

nicoddemus commented Aug 11, 2017

Fixed by #2650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.