Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest 3.3: tests being skipped without failing #2975

Closed
argaen opened this Issue Nov 29, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@argaen
Copy link

commented Nov 29, 2017

After updating to pytest==3.3, some tests of our pipeline started to be skipped while in previous versions where being run without problems.

Haven't seen anything relevant enough in the release notes and this is an important since skipping tests may lead to deploy broken stacks to production...

In our case, it's due to using test_client fixture from pytest-aiohttp:

async def test_whatever(test_client):
    pass
16:47 $ pytest test_test.py -svvv
============================================================================================================================= test session starts ==============================================================================================================================
platform darwin -- Python 3.5.2, pytest-3.3.0, py-1.5.2, pluggy-0.6.0 -- /Users/manuelmiranda/.pyenv/versions/3.5.2/envs/play/bin/python
cachedir: .cache
rootdir: /Users/manuelmiranda/Projects/testproject, inifile:
plugins: mock-1.6.3, cov-2.5.1, asyncio-0.8.0, aiohttp-0.1.3
collected 1 item

test_test.py::test_whatever[loop0] SKIPPED                                                                                                                                                                                                                               [100%]

========================================================================================================================== 1 skipped in 0.01 seconds ===========================================================================================================================

Environment:

pytest==3.3.0
pytest-aiohttp=0.1.3

The fixture from pytest-aiohttp can be found in https://github.com/aio-libs/aiohttp/blob/master/aiohttp/pytest_plugin.py#L264. Maybe it is the fixture that is doing something wrong. If that's the case lets open an issue there but I think it would be useful a big disclaimer in the new release notes regarding this behavior change

@argaen

This comment has been minimized.

Copy link
Author

commented Nov 29, 2017

Closing in favor of #2959 which are the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.