Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4.0 logging changes break devpi tests #3181

Closed
fschulze opened this Issue Feb 1, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@fschulze
Copy link
Contributor

fschulze commented Feb 1, 2018

The logging changes in 3.4.0 break devpi tests and I couldn't yet figure out why. I guess it has to do with the changes regarding log levels. I don't get any log records at all now. I haven't worked through the whole PR #3124 yet.

Shouldn't this have been a 4.0.0 with such incompatible changes? I mean, even the changelog says "incompatible changes".

@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Feb 1, 2018

@fschulze did you see the section https://docs.pytest.org/en/latest/logging.html#incompatible-changes-in-pytest-3-4 in the docs? That should restore the log messages.

Shouldn't this have been a 4.0.0 with such incompatible changes? I mean, even the changelog says "incompatible changes".

Perhaps, but in general we allow changing defaults between minor releases, given that introduce a warning between releases before actually changing the defaults.

But in the case of logging, we had to change the defaults because a lot of people reported not being able to use 3.3 at all because of the defaults being used. This happened probably because the actual code that was merged was never used in the wild (we merged pytest-catchlog master which contained more features than the released version).

What we had learned from this lesson is that we probably need to be more careful when introducing new plugins in the core, specially those that integrate with well used facilities such as logging. 😬

@fschulze

This comment has been minimized.

Copy link
Contributor Author

fschulze commented Feb 1, 2018

@nicoddemus I worked it out, the "NOTSET" setting was the clue I needed. I wanted to fix it on the Python level instead of the config level though, because as usual devpi uses some internals 😜

@fschulze fschulze closed this Feb 1, 2018

@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Feb 1, 2018

Great! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.