New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate resultlog #830

Closed
RonnyPfannschmidt opened this Issue Jul 11, 2015 · 15 comments

Comments

Projects
None yet
5 participants
@RonnyPfannschmidt
Member

RonnyPfannschmidt commented Jul 11, 2015

the format is incomplete and tricky to parse,
i propose deprecating it in 2.8 and scheduling full removal for when pypy uses something more modern

a more complete replacement will be proposed at a later point in time

@RonnyPfannschmidt RonnyPfannschmidt added this to the 2.8 milestone Jul 11, 2015

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Jul 11, 2015

Hmm I have never used it... could you explain the motivation for the plugin to exist in the first place and what pypy has to do with it?

I kind of agree about it being difficult to parse... perhaps it would be better to produce the contents in something easier to parse, like JSON perhaps?

Thanks!

@RonnyPfannschmidt

This comment has been minimized.

Member

RonnyPfannschmidt commented Jul 12, 2015

resultog is basically the first variant of semi-structured output of test results for later consumption

it was created years before json was as well known as today

pypy uses it for its execution result analysis

these days a format like subunit or a general stream of json objects (one per line) seems far more helpful

such a format could also be used for more detailed pytest debugging, (since trace items could be part of sucha stream without creating unwanted intersection)

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Jul 12, 2015

I see, thanks for the explanation! 😄

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Sep 26, 2015

Should this be updated to 2.9 now that 2.8 is out already?

@RonnyPfannschmidt RonnyPfannschmidt modified the milestones: 2.9, 2.8.1 Sep 27, 2015

@RonnyPfannschmidt RonnyPfannschmidt changed the title from deprecate resultlog in 2.8 to deprecate resultlog in 2.9 Sep 27, 2015

@The-Compiler The-Compiler modified the milestones: 2.10, 2.9 Feb 26, 2016

@The-Compiler The-Compiler changed the title from deprecate resultlog in 2.9 to deprecate resultlog Feb 26, 2016

@nicoddemus nicoddemus modified the milestones: 2.10, 3.0 Jun 26, 2016

@The-Compiler

This comment has been minimized.

Member

The-Compiler commented Aug 5, 2016

Should we do this for 3.0 as it's backwards-incompatible but probably relatively straightforward?

@RonnyPfannschmidt

This comment has been minimized.

Member

RonnyPfannschmidt commented Aug 5, 2016

yes please

nicoddemus added a commit to nicoddemus/pytest that referenced this issue Aug 16, 2016

nicoddemus added a commit to nicoddemus/pytest that referenced this issue Aug 16, 2016

nicoddemus added a commit to nicoddemus/pytest that referenced this issue Aug 17, 2016

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Aug 17, 2016

Fixed in #1812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment