Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break up the runtestprotocol and create a sequence of setup/teardown/call actions #895

Open
RonnyPfannschmidt opened this issue Jul 27, 2015 · 3 comments

Comments

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Jul 27, 2015

the current usage of setupstate and runtestprotocol creates problematic quirks with tear-down,
to elevate that problem and separate reports better, we should instead have a generator for setup/teardown actions and use those to report setup of items and fixtures as well as the running of items

that way we could remove the need for next-item and ensure each report is much more specific

@RonnyPfannschmidt RonnyPfannschmidt added this to the 3.0 milestone Jul 27, 2015
@The-Compiler

This comment has been minimized.

Copy link
Member

@The-Compiler The-Compiler commented Aug 5, 2016

I don't understand this issue, but I doubt it should block 3.0. Let me know if you disagree.

@The-Compiler The-Compiler modified the milestones: 3.1.0, 3.0 Aug 5, 2016
@RonnyPfannschmidt RonnyPfannschmidt modified the milestones: 4.0, 3.1.0 Aug 5, 2016
@nicoddemus nicoddemus modified the milestones: 4.0, 4.1 Nov 22, 2018
@nicoddemus

This comment has been minimized.

Copy link
Member

@nicoddemus nicoddemus commented Dec 18, 2018

@RonnyPfannschmidt is this something you want to tackle for 4.1 or 4.2 still?

@RonnyPfannschmidt

This comment has been minimized.

Copy link
Member Author

@RonnyPfannschmidt RonnyPfannschmidt commented Dec 19, 2018

@nicoddemus i beelive its more of a 6.0 or 7.0 thing - it will require breaking changes

before delving into it i'd like to resolve config, nodes and storage apis since doing it before would incur really bad and strange tech debt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.