runner: don't treat unittest.SkipTest as an interactive exception
#13924
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of special casing in the debugging plugin, it seems more correct to just not treat `unittest.SkipTest` as an interactive exception, similarly to pytest's own `Skipped`. The `pytest_make_collect_report` hook in runner.py already treats them the same. This fixes the issue more generally.
psf-chronographer
bot
added
the
bot:chronographer:provided
nicoddemus
added
the
backport 9.0.x
bluetech
removed
the
backport 9.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13917.
Instead of special casing in the debugging plugin, it seems more correct to just not treat
unittest.SkipTestas an interactive exception, similarly to pytest's ownSkipped. Thepytest_make_collect_reporthook in runner.py already treats them the same. This fixes the issue more generally.