Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Improve error message for CollectError with skip/skipif #2546

Merged
merged 1 commit into from Jul 25, 2017

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 4, 2017

TODO:

  • squash!
@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Jul 4, 2017

Thanks, looks good! Would you mind adding a "trivial" changelog file as well?

@coveralls
Copy link

@coveralls coveralls commented Jul 4, 2017

Coverage Status

Coverage remained the same at 92.138% when pulling 52d4920 on blueyed:better-skip-not-allowed-error into 6908d93 on pytest-dev:master.

@coveralls
Copy link

@coveralls coveralls commented Jul 4, 2017

Coverage Status

Coverage remained the same at 92.138% when pulling 52d4920 on blueyed:better-skip-not-allowed-error into 6908d93 on pytest-dev:master.

Copy link
Member

@nicoddemus nicoddemus left a comment

Please add a "trivial" changelog file as well. It is nice to document small/trivial changes which might affect users.

Other than that LGTM.

@blueyed blueyed force-pushed the blueyed:better-skip-not-allowed-error branch from 52d4920 to 72531f3 Jul 25, 2017
@blueyed
Copy link
Contributor Author

@blueyed blueyed commented Jul 25, 2017

Added the changelog entry and rebased it.

@coveralls
Copy link

@coveralls coveralls commented Jul 25, 2017

Coverage Status

Coverage remained the same at 92.056% when pulling 72531f3 on blueyed:better-skip-not-allowed-error into 70d9f86 on pytest-dev:master.

Copy link
Member

@nicoddemus nicoddemus left a comment

Awesome, thanks!

@nicoddemus nicoddemus merged commit 71947cb into pytest-dev:master Jul 25, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@blueyed blueyed deleted the blueyed:better-skip-not-allowed-error branch Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants