New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lineno offset in show_skipped #2548

Merged
merged 1 commit into from Jul 25, 2017

Conversation

Projects
None yet
3 participants
@blueyed
Contributor

blueyed commented Jul 4, 2017

The line number is 0-based here, so add 1.

I've done similar fixes before, and asked already before if this should be fixed more upwards in the end, since it seems to cripple down everywhere?!

@blueyed blueyed added the type: bug label Jul 4, 2017

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Jul 4, 2017

I've done similar fixes before, and asked already before if this should be fixed more upwards in the end, since it seems to cripple down everywhere?!

Unfortunately it is not so simple because it might break other plugins which depend on that lineno being zero-based. ☹️

@nicoddemus

nicoddemus requested changes Jul 4, 2017 edited

Please add a simple test to avoid getting a regression in the future. Please fix the current tests which are incorrect (apparently). 😉

While at it, would you mind reviewing the other status (xfail, xpass, etc) to see if they have the same problem?

Fix lineno offset in show_skipped
The line number is 0-based here, so add 1.
@blueyed

This comment has been minimized.

Contributor

blueyed commented Jul 25, 2017

Updated. Adjusted the one failing test, and added a changelog entry.

@coveralls

This comment has been minimized.

coveralls commented Jul 25, 2017

Coverage Status

Coverage remained the same at 92.056% when pulling 869eed9 on blueyed:skip-fix-lineno into 70d9f86 on pytest-dev:master.

@nicoddemus nicoddemus merged commit 595ecd2 into pytest-dev:master Jul 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Jul 25, 2017

Thanks @blueyed!

@blueyed blueyed deleted the blueyed:skip-fix-lineno branch Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment