Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove preinit, its no longer needed #2636

Merged

Conversation

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Jul 31, 2017

by removing preinit we remove loading the initial plugin list

this is no longer needed, since we no longer use pytest-namespace for pytest itself

the followup for this one is to deprecate the pytest-namespace hook alltogether

@RonnyPfannschmidt RonnyPfannschmidt changed the base branch from master to features Jul 31, 2017
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:remove-preinit branch from f6f422c to 34909f2 Jul 31, 2017
@coveralls
Copy link

@coveralls coveralls commented Jul 31, 2017

Coverage Status

Coverage decreased (-0.005%) to 91.81% when pulling 34909f2 on RonnyPfannschmidt:remove-preinit into f1467f8 on pytest-dev:features.

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:remove-preinit branch from 34909f2 to c68a89b Jul 31, 2017
@RonnyPfannschmidt RonnyPfannschmidt requested review from nicoddemus and hpk42 Jul 31, 2017
@coveralls
Copy link

@coveralls coveralls commented Jul 31, 2017

Coverage Status

Coverage decreased (-0.005%) to 91.81% when pulling e90f876 on RonnyPfannschmidt:remove-preinit into f1467f8 on pytest-dev:features.

@coveralls
Copy link

@coveralls coveralls commented Jul 31, 2017

Coverage Status

Coverage decreased (-0.007%) to 91.808% when pulling e90f876 on RonnyPfannschmidt:remove-preinit into f1467f8 on pytest-dev:features.

Copy link
Member

@nicoddemus nicoddemus left a comment

Nice work!

IMHO we need a small adjustment to the changelog and this is good to go!

@@ -0,0 +1 @@
- remove plugin preinit, we no longer need to do that because the namespace is initialized in the module now

This comment has been minimized.

@nicoddemus

nicoddemus Jul 31, 2017
Member

I suggest to make this more user oriented, the way it is now I doubt the general user will understand it. How about:

Remove internal ``_preloadplugins()`` function. This removal is part of the ``pytest_namespace()`` hook deprecation.

This comment has been minimized.

@coveralls
Copy link

@coveralls coveralls commented Jul 31, 2017

Coverage Status

Coverage decreased (-0.007%) to 91.808% when pulling dcaeef7 on RonnyPfannschmidt:remove-preinit into f1467f8 on pytest-dev:features.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 6e75472 into pytest-dev:features Aug 1, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RonnyPfannschmidt RonnyPfannschmidt mentioned this pull request Aug 1, 2017
4 of 4 tasks complete
@RonnyPfannschmidt RonnyPfannschmidt deleted the RonnyPfannschmidt:remove-preinit branch Nov 13, 2017
@uSpike uSpike mentioned this pull request Nov 27, 2017
nicoddemus added a commit that referenced this pull request Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants