Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure callspecs contain the list of marks #2675

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
3 participants
@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Aug 10, 2017

this ensures we don't override in that area

the final parts of the transfer are still broken, but with the list, we at least have a chance to do better in future

this is also base to fix #1540 in future

@RonnyPfannschmidt RonnyPfannschmidt requested review from nicoddemus , The-Compiler and hpk42 and removed request for nicoddemus Aug 10, 2017

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:mark-callspeck branch from df81b08 to c09055c Aug 10, 2017

RonnyPfannschmidt added a commit to RonnyPfannschmidt/pytest that referenced this pull request Aug 10, 2017

@pytest-dev pytest-dev deleted a comment from coveralls Aug 10, 2017

@pytest-dev pytest-dev deleted a comment from coveralls Aug 10, 2017

@@ -67,10 +67,6 @@ def extract_from(cls, parameterset, legacy_force_tuple=False):

return cls(argval, marks=newmarks, id=None)

@property
def deprecated_arg_dict(self):

This comment has been minimized.

@nicoddemus

nicoddemus Aug 10, 2017

Member

I suppose this was never part of the public API given that it is a method of the new ParameterSet class, but if I'm wrong then we should add a removal changelog note.

This comment has been minimized.

@RonnyPfannschmidt

RonnyPfannschmidt Aug 10, 2017

Author Member

it was a naming error, but we should add a removal message anyway

@@ -0,0 +1 @@
Internally change CallSpec2 to have a list of marks instead of a broken mapping of keywords

This comment has been minimized.

@nicoddemus

nicoddemus Aug 10, 2017

Member

Nit: add a . a the end of the sentence. 😁

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:mark-callspeck branch from c09055c to eb46258 Aug 10, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage decreased (-0.0009%) to 91.986% when pulling eb46258 on RonnyPfannschmidt:mark-callspeck into 9e62a31 on pytest-dev:features.

@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Aug 10, 2017

This actually fixes #2672 btw, and not #2675 (which is the PR id) as it says in the commit message. 😉

@nicoddemus nicoddemus merged commit 5f17caa into pytest-dev:features Aug 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RonnyPfannschmidt RonnyPfannschmidt deleted the RonnyPfannschmidt:mark-callspeck branch Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.