Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error in 'Good Practices' code snippet #2691

Merged
merged 1 commit into from Aug 16, 2017

Conversation

@anhiga
Copy link
Contributor

@anhiga anhiga commented Aug 15, 2017

When initializing with pytest_args = [], if no arguments are passed, shlex.split fails parsing the empty list.
It can be easily fixed by initializing with pytest_args = ''.


Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS;
Copy link
Member

@nicoddemus nicoddemus left a comment

Thanks, appreciate it!

@coveralls
Copy link

@coveralls coveralls commented Aug 15, 2017

Coverage Status

Coverage remained the same at 91.805% when pulling 2a99d82 on anhiga:trivial_error into 9b2753b on pytest-dev:master.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 806d47b into pytest-dev:master Aug 16, 2017
2 checks passed
@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Aug 16, 2017

good find, thanks for the fix 👍

@anhiga anhiga deleted the trivial_error branch Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants