Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2731.bug Fix ReprFuncArgs with mixed unicode and utf-8 args. #2735

Merged
merged 1 commit into from Aug 31, 2017
Merged

2731.bug Fix ReprFuncArgs with mixed unicode and utf-8 args. #2735

merged 1 commit into from Aug 31, 2017

Conversation

fgmacedo
Copy link
Contributor

The class _pytest._code.code.ReprFuncArgs crashes with UnicodeDecodeError when trying to write args with mixed unicode and utf-8 strings.

Fixes #2731.

@fgmacedo fgmacedo mentioned this pull request Aug 30, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.805% when pulling 59cdef9 on fgmacedo:fgm-fix-reprfuncargs-toterminal into 709b8b6 on pytest-dev:master.

nicoddemus
nicoddemus approved these changes Aug 31, 2017
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@RonnyPfannschmidt RonnyPfannschmidt merged commit 5e00549 into pytest-dev:master Aug 31, 2017
@RonnyPfannschmidt
Copy link
Member

well done, thanks

@fgmacedo
Copy link
Contributor Author

Thank you guys! I'm a big fan of this project! You're doing an amazing job! 👏

@nicoddemus
Copy link
Member

Thanks for the compliment, we appreciate it. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fgmacedo @coveralls @RonnyPfannschmidt @nicoddemus