New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in example of passing a callable to markers #2765

Merged
merged 2 commits into from Sep 10, 2017

Conversation

Projects
None yet
3 participants
@xuanluong
Contributor

xuanluong commented Sep 9, 2017

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS;
@coveralls

This comment has been minimized.

coveralls commented Sep 9, 2017

Coverage Status

Changes Unknown when pulling e27a0d6 on xuanluong:pass-callable-to-marker-typo into ** on pytest-dev:master**.

@coveralls

This comment has been minimized.

coveralls commented Sep 9, 2017

Coverage Status

Coverage remained the same at 91.805% when pulling e27a0d6 on xuanluong:pass-callable-to-marker-typo into 3c1ca03 on pytest-dev:master.

@nicoddemus nicoddemus merged commit bee2c86 into pytest-dev:master Sep 10, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Sep 10, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment