Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytester: ignore files used to obtain current user metadata #2784

Merged
merged 1 commit into from Dec 19, 2017

Conversation

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Sep 16, 2017

… fd leak detector

@@ -22,6 +22,11 @@
from _pytest.assertion.rewrite import AssertionRewritingHook


IGNORE_PAM = [ # filenames added when obtaining details about the current user
Copy link
Member

@nicoddemus nicoddemus Sep 16, 2017

What's "PAM"?

Copy link
Member Author

@RonnyPfannschmidt RonnyPfannschmidt Sep 17, 2017

thanks for noting, pam comes frim the plugablle authentification modules, the SSS module is the one that opens this file, constant however is indeed named bdly

@@ -0,0 +1 @@
pytester: no ignore files used to obtain current user metadata in the fd leak detector
Copy link
Member

@nicoddemus nicoddemus Sep 16, 2017

IIUC this should be "ignore files", not "no ignore files", right?

@@ -0,0 +1 @@
pytester: no ignore files used to obtain current user metadata in the fd leak detector
Copy link
Member

@nicoddemus nicoddemus Sep 16, 2017

Nit: please add a "." at the end of the sentence. 😉

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Nov 10, 2017

@RonnyPfannschmidt gentle ping.

@RonnyPfannschmidt
Copy link
Member Author

@RonnyPfannschmidt RonnyPfannschmidt commented Dec 18, 2017

will retry after #3016

@RonnyPfannschmidt RonnyPfannschmidt changed the title pytester: no ignore files used to obtain current user metadata in the… pytester: ignore files used to obtain current user metadata Dec 18, 2017
@coveralls
Copy link

@coveralls coveralls commented Dec 18, 2017

Coverage Status

Coverage decreased (-0.02%) to 92.565% when pulling ed293ec on RonnyPfannschmidt:fix-fdleaks into 2f8427b on pytest-dev:master.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 672c901 into pytest-dev:master Dec 19, 2017
2 checks passed
@RonnyPfannschmidt RonnyPfannschmidt deleted the fix-fdleaks branch Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants