Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytester: ignore files used to obtain current user metadata #2784

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Sep 16, 2017

… fd leak detector

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:fix-fdleaks branch from 709af12 to 6935e9d Sep 16, 2017

@@ -22,6 +22,11 @@
from _pytest.assertion.rewrite import AssertionRewritingHook


IGNORE_PAM = [ # filenames added when obtaining details about the current user

This comment has been minimized.

@nicoddemus

nicoddemus Sep 16, 2017

Member

What's "PAM"?

This comment has been minimized.

@RonnyPfannschmidt

RonnyPfannschmidt Sep 17, 2017

Author Member

thanks for noting, pam comes frim the plugablle authentification modules, the SSS module is the one that opens this file, constant however is indeed named bdly

@@ -0,0 +1 @@
pytester: no ignore files used to obtain current user metadata in the fd leak detector

This comment has been minimized.

@nicoddemus

nicoddemus Sep 16, 2017

Member

IIUC this should be "ignore files", not "no ignore files", right?

@@ -0,0 +1 @@
pytester: no ignore files used to obtain current user metadata in the fd leak detector

This comment has been minimized.

@nicoddemus

nicoddemus Sep 16, 2017

Member

Nit: please add a "." at the end of the sentence. 😉

@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Nov 10, 2017

@RonnyPfannschmidt gentle ping.

@RonnyPfannschmidt

This comment has been minimized.

Copy link
Member Author

RonnyPfannschmidt commented Dec 18, 2017

will retry after #3016

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:fix-fdleaks branch from 6935e9d to 2f05375 Dec 18, 2017

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:fix-fdleaks branch from 2f05375 to ed293ec Dec 18, 2017

@RonnyPfannschmidt RonnyPfannschmidt changed the title pytester: no ignore files used to obtain current user metadata in the… pytester: ignore files used to obtain current user metadata Dec 18, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 18, 2017

Coverage Status

Coverage decreased (-0.02%) to 92.565% when pulling ed293ec on RonnyPfannschmidt:fix-fdleaks into 2f8427b on pytest-dev:master.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 672c901 into pytest-dev:master Dec 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RonnyPfannschmidt RonnyPfannschmidt deleted the RonnyPfannschmidt:fix-fdleaks branch Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.