Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Failed exception to manage maxfail behavior #2845

Merged
merged 2 commits into from Oct 19, 2017

Conversation

Projects
None yet
4 participants
@jespino
Copy link
Contributor

jespino commented Oct 17, 2017

As I explained in the issue #2832, I'm not sure that the behavior is incorrect by itself, but have sense both options, interrupt return, and failed return. Anyway, I prefer to have failed return and leave "interrupt" to explicit user interruptions, like Ctrl-C.

@jespino jespino referenced this pull request Oct 17, 2017

Closed

exit code 2 when using '-x' flag #2832

3 of 4 tasks complete

@jespino jespino force-pushed the jespino:fix/2832 branch to c5550bc Oct 17, 2017

@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt left a comment

good initial work 👍

due to the nature of the bugfix here i believe its better to target the features branch here

please also add a test that demonstrates the behaviour in the testsuite as well as a changelog entry

@jespino jespino changed the base branch from master to features Oct 17, 2017

@jespino jespino force-pushed the jespino:fix/2832 branch 4 times, most recently from f690161 to 00d3abe Oct 17, 2017

@jespino

This comment has been minimized.

Copy link
Contributor Author

jespino commented Oct 17, 2017

Added a changelog entry, changed the branch to merge to feature, and the current tests are changed to validate the new behavior. The existing test already test the behavior.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 17, 2017

Coverage Status

Coverage decreased (-0.01%) to 92.658% when pulling 00d3abe on jespino:fix/2832 into 71c76d9 on pytest-dev:features.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-0.01%) to 92.658% when pulling f690161 on jespino:fix/2832 into 71c76d9 on pytest-dev:features.

@nicoddemus

This comment has been minimized.

Copy link
Member

nicoddemus commented Oct 18, 2017

The existing test already test the behavior.

I agree that's enough, unless @RonnyPfannschmidt has something else to test in mind.

The two failing tests are unrelated (#2843).

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-0.01%) to 92.658% when pulling e81b275 on jespino:fix/2832 into 71c76d9 on pytest-dev:features.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 3f9f4be into pytest-dev:features Oct 19, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jespino jespino deleted the jespino:fix/2832 branch Oct 19, 2017

@blueyed blueyed referenced this pull request Nov 29, 2017

Merged

pytest: handle non-zero exit code #313

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.