Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move responsibility for parameterset extraction into parameterset class #2877

Merged

Conversation

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Oct 27, 2017

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS, in alphabetical order;
@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:extract-extract-parameterset branch from 46baf87 to 4a436f2 Oct 27, 2017
@coveralls
Copy link

@coveralls coveralls commented Oct 27, 2017

Coverage Status

Coverage increased (+0.004%) to 92.683% when pulling 4a436f2 on RonnyPfannschmidt:extract-extract-parameterset into def471b on pytest-dev:features.

@coveralls
Copy link

@coveralls coveralls commented Oct 27, 2017

Coverage Status

Coverage increased (+0.004%) to 92.683% when pulling 4a436f2 on RonnyPfannschmidt:extract-extract-parameterset into def471b on pytest-dev:features.

Copy link
Member

@nicoddemus nicoddemus left a comment

Nice refactoring 👍

@nicoddemus nicoddemus merged commit 7d43225 into pytest-dev:features Nov 3, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@RonnyPfannschmidt RonnyPfannschmidt deleted the RonnyPfannschmidt:extract-extract-parameterset branch Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants