Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify language of proposal for fixtures parameters #2893

Merged
merged 2 commits into from Nov 4, 2017

Conversation

@fmichea
Copy link
Contributor

@fmichea fmichea commented Nov 3, 2017

This change slightly modifies the language of the proposal document around use of fixture as parameters of pytest.mark.parametrize.

When looking for documentation around this, I very quickly scrolled through this document and landed on the last paragraph thinking it was documenting a real function. This change attempts to make it less likely for this to happen.

fmichea added 2 commits Nov 3, 2017
This change slightly modifies the language of the proposal document around use of fixture as parameters of pytest.mark.parametrize. When looking for documentation around this, I very quickly scrolled through this document and landed on the last paragraph thinking it was documenting a real function. This change attempts to make it less likely for this to happen.
@coveralls
Copy link

@coveralls coveralls commented Nov 3, 2017

Coverage Status

Coverage remained the same at 92.244% when pulling 22e9b00 on fmichea:patch-1 into cd747c4 on pytest-dev:master.

@coveralls
Copy link

@coveralls coveralls commented Nov 3, 2017

Coverage Status

Coverage remained the same at 92.244% when pulling 22e9b00 on fmichea:patch-1 into cd747c4 on pytest-dev:master.

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Nov 4, 2017

the failure is a unrelated windows encding issue
CC @nicoddemus

@RonnyPfannschmidt RonnyPfannschmidt merged commit 2e2f721 into pytest-dev:master Nov 4, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants