Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #3015

Merged
merged 11 commits into from Dec 12, 2017
Merged

Code cleanup #3015

merged 11 commits into from Dec 12, 2017

Conversation

@jurko-gospodnetic
Copy link
Contributor

@jurko-gospodnetic jurko-gospodnetic commented Dec 8, 2017

Code cleanup done while working on another pull request and extracted here so it would not cloud up the original pull request.

@jurko-gospodnetic jurko-gospodnetic force-pushed the jurko-gospodnetic:code-cleanup branch from 855b4af to db10629 Dec 8, 2017
@coveralls
Copy link

@coveralls coveralls commented Dec 8, 2017

Coverage Status

Coverage remained the same at 92.7% when pulling 855b4af on jurko-gospodnetic:code-cleanup into 1c5b887 on pytest-dev:master.

@jurko-gospodnetic jurko-gospodnetic force-pushed the jurko-gospodnetic:code-cleanup branch 2 times, most recently from a73fbde to c278b47 Dec 8, 2017
@coveralls
Copy link

@coveralls coveralls commented Dec 8, 2017

Coverage Status

Coverage remained the same at 92.7% when pulling 855b4af on jurko-gospodnetic:code-cleanup into 1c5b887 on pytest-dev:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 8, 2017

Coverage Status

Coverage remained the same at 92.7% when pulling a73fbde on jurko-gospodnetic:code-cleanup into 1c5b887 on pytest-dev:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 8, 2017

Coverage Status

Coverage remained the same at 92.7% when pulling c278b47 on jurko-gospodnetic:code-cleanup into 1c5b887 on pytest-dev:master.

@jurko-gospodnetic jurko-gospodnetic force-pushed the jurko-gospodnetic:code-cleanup branch from c278b47 to b05bdf0 Dec 9, 2017
@jurko-gospodnetic jurko-gospodnetic force-pushed the jurko-gospodnetic:code-cleanup branch from b05bdf0 to 73bc6ba Dec 9, 2017
@coveralls
Copy link

@coveralls coveralls commented Dec 9, 2017

Coverage Status

Coverage remained the same at 92.7% when pulling 73bc6ba on jurko-gospodnetic:code-cleanup into 964c29c on pytest-dev:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 9, 2017

Coverage Status

Coverage remained the same at 92.7% when pulling 73bc6ba on jurko-gospodnetic:code-cleanup into 964c29c on pytest-dev:master.

# mixed module and filenames:
os.chdir('world')

This comment has been minimized.

@RonnyPfannschmidt

RonnyPfannschmidt Dec 9, 2017
Member

this code<> commend swap looks unintended

This comment has been minimized.

@jurko-gospodnetic

jurko-gospodnetic Dec 9, 2017
Author Contributor

actually I thought it seemed correct - there are two pytest runs here and for each we set up a suitable cwd folder

easy enough to revert if you dislike it, I'm just curious as to what the intended meaning here was then

This comment has been minimized.

@RonnyPfannschmidt

RonnyPfannschmidt Dec 9, 2017
Member

true, in full context it looks correct after all - before this change the lines where directly matching the code in question, but now its indeed marking the test sections instead

@RonnyPfannschmidt
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt commented Dec 9, 2017

overall good work on many many little details 👍

@coveralls
Copy link

@coveralls coveralls commented Dec 11, 2017

Coverage Status

Coverage remained the same at 92.7% when pulling 3b85e0c on jurko-gospodnetic:code-cleanup into 964c29c on pytest-dev:master.

Copy link
Member

@nicoddemus nicoddemus left a comment

Nice cleanup, thanks @jurko-gospodnetic!

@nicoddemus nicoddemus merged commit 5c6d773 into pytest-dev:master Dec 12, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jurko-gospodnetic jurko-gospodnetic deleted the jurko-gospodnetic:code-cleanup branch Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants