Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer https://*.readthedocs.io over http://*.rtfd.org #3092

Merged
merged 2 commits into from Jan 6, 2018

Conversation

@jdufresne
Copy link
Contributor

@jdufresne jdufresne commented Jan 6, 2018

  • Requests URL using https instead of http
  • Avoids unnecessary redirect of *.rtfd.org -> *.readthedocs.io

*.rtfd.org exists as a means for pasting short URLs, which doesn't much apply for links in documentation.

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Add a new news fragment into the changelog folder
    • name it $issue_id.$type for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
  • Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
  • Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS, in alphabetical order;
- Requests URL using https instead of http
- Avoids unnecessary redirect of *.rtfd.org -> *.readthedocs.io

*.rtfd.org exists as a means for pasting short URLs, which doesn't much
 apply for links in documentation.
@jdufresne jdufresne force-pushed the jdufresne:readthedocs branch from ed3429a to b93aa5e Jan 6, 2018
Copy link
Member

@nicoddemus nicoddemus left a comment

LGTM, thanks!

@coveralls
Copy link

@coveralls coveralls commented Jan 6, 2018

Coverage Status

Coverage remained the same at 92.565% when pulling f3c666d on jdufresne:readthedocs into bc66f7e on pytest-dev:master.

@nicoddemus nicoddemus merged commit 29ff930 into pytest-dev:master Jan 6, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@jdufresne jdufresne deleted the jdufresne:readthedocs branch Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants