Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of Getting Started guide #3131

Merged
merged 9 commits into from Jan 23, 2018
Merged

Conversation

@soyrice
Copy link

@soyrice soyrice commented Jan 18, 2018

New pytest user here! Updated the Getting Started guide to be more readable for new users. Improved grammar, phrasing, etc.

Cyrus Maden added 5 commits Jan 15, 2018
Proofread; added intro paragraph under first header to orient new users; fixed grammar errors (switched to active voice, actionable directions, etc) to improve readability
Not issue ID. Will update with pr ID after submitting pr
@coveralls
Copy link

@coveralls coveralls commented Jan 19, 2018

Coverage Status

Coverage remained the same at 92.558% when pulling cd76366 on soyrice:master into 6213746 on pytest-dev:master.

Copy link
Member

@The-Compiler The-Compiler left a comment

Thanks! I haven't looked at the text in detail yet, but can you please remove the .DS_Store files?

@soyrice
Copy link
Author

@soyrice soyrice commented Jan 20, 2018

Done :)

@coveralls
Copy link

@coveralls coveralls commented Jan 20, 2018

Coverage Status

Coverage remained the same at 92.558% when pulling 0b6df94 on soyrice:master into 6213746 on pytest-dev:master.

@coveralls
Copy link

@coveralls coveralls commented Jan 20, 2018

Coverage Status

Coverage remained the same at 92.558% when pulling 0b6df94 on soyrice:master into 6213746 on pytest-dev:master.

Copy link
Member

@nicoddemus nicoddemus left a comment

Just a minor typo but LGTM! Thanks a lot! 😁

@@ -177,22 +160,21 @@ before performing the test function call. Let's just run it::
PYTEST_TMPDIR/test_needsfiles0
1 failed in 0.12 seconds

Before the test runs, a unique-per-test-invocation temporary directory
was created. More info at :ref:`tmpdir handling`.
More info on tmpdir handeling is available at `Temporary directories and files <tmpdir handling>`_.

This comment has been minimized.

@nicoddemus

nicoddemus Jan 20, 2018
Member

typo: handeling

@coveralls
Copy link

@coveralls coveralls commented Jan 20, 2018

Coverage Status

Coverage remained the same at 92.558% when pulling 0ab57c4 on soyrice:master into 6213746 on pytest-dev:master.

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Jan 23, 2018

Thanks @soyrice.

Let's wait for @The-Compiler's review before merging. 👍

@The-Compiler
Copy link
Member

@The-Compiler The-Compiler commented Jan 23, 2018

No time right now thanks to exams, so feel free to go ahead 😉

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Jan 23, 2018

OK then! 👍

@nicoddemus nicoddemus merged commit baa189f into pytest-dev:master Jan 23, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants