Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show deselection count before tests are executed #3213

Merged
merged 2 commits into from Feb 17, 2018

Conversation

@thisch
Copy link
Contributor

@thisch thisch commented Feb 13, 2018

Fixes #1527

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS in alphabetical order;
@thisch thisch force-pushed the thisch:collection_deselection branch from 9af213c to 6cb1ae0 Feb 13, 2018
@thisch thisch changed the title Show deselection count before tests are exectued Show deselection count before tests are executed Feb 13, 2018
@thisch thisch force-pushed the thisch:collection_deselection branch from 6cb1ae0 to 97e712c Feb 13, 2018
@thisch thisch force-pushed the thisch:collection_deselection branch from 97e712c to 6496131 Feb 13, 2018
@coveralls
Copy link

@coveralls coveralls commented Feb 13, 2018

Coverage Status

Coverage decreased (-0.0008%) to 92.638% when pulling df2f019 on thisch:collection_deselection into 063e2da on pytest-dev:features.

@thisch
Copy link
Contributor Author

@thisch thisch commented Feb 14, 2018

@fontealpina, @nicoddemus and @arunksaha: Can you test this PR please and give me some feedback?

@arunksaha: You suggested the --list-deselected parameter in #1527. Are you interested and have time to contribute to pytest and work on this?

@nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented Feb 15, 2018

@thisch I tested it and looks great, thanks a ton!

@nicoddemus nicoddemus merged commit fa8354e into pytest-dev:features Feb 17, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arunksaha
Copy link

@arunksaha arunksaha commented Feb 17, 2018

@thisch Thank you for creating and submitting the patch. I am not familiar with the pytest internals, it might take a while for me.

@nicoddemus Thank you fot testing and merging.

@thisch thisch deleted the thisch:collection_deselection branch Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants