Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimal attrs library to v17.4.0 #3228

merged 2 commits into from Feb 17, 2018


None yet
4 participants
Copy link

thisch commented Feb 15, 2018

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS in alphabetical order;

@thisch thisch changed the title Update attr Update minimal attrs library to v17.4.0 Feb 15, 2018

@thisch thisch changed the base branch from master to features Feb 15, 2018

@feuillemorte feuillemorte requested review from nicoddemus and removed request for nicoddemus Feb 15, 2018


This comment has been minimized.

Copy link

RonnyPfannschmidt commented Feb 15, 2018

can we additionally opt in to warnings from attrs for the test runs so we note such details earlier?


This comment has been minimized.

Copy link

coveralls commented Feb 15, 2018

Coverage Status

Coverage remained the same at 92.639% when pulling 82cdc48 on thisch:update_attr into 063e2da on pytest-dev:features.


This comment has been minimized.

Copy link

nicoddemus commented Feb 17, 2018

The unrelated failure in py37 has already been fixed on the latest features, so merging. 👍

@nicoddemus nicoddemus merged commit 3bc8b50 into pytest-dev:features Feb 17, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build is in progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.