Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move some code and make nodeid computed early #3291

merged 7 commits into from Mar 12, 2018


Copy link

@RonnyPfannschmidt RonnyPfannschmidt commented Mar 9, 2018

@nicoddemus i had some local failures wrt progress display on xdist, if that shows up on travis as well please have a look

@RonnyPfannschmidt RonnyPfannschmidt changed the base branch from master to features Mar 9, 2018
Copy link

@coveralls coveralls commented Mar 9, 2018

Coverage Status

Coverage increased (+0.06%) to 92.726% when pulling 0302622 on RonnyPfannschmidt:small-moves into d6ddeb3 on pytest-dev:features.

Copy link

@nicoddemus nicoddemus left a comment

@RonnyPfannschmidt this looks fine, I'm curious why you think it is better to be able to pass in the nodeid instead of having it computed always (I have a few reasons but I would like to hear yours first 😁).

Also, I guess this warrants a trivial CHANGELOG entry.

@@ -319,31 +282,34 @@ def _prunetraceback(self, excinfo):
excinfo.traceback = ntraceback.filter()

def _check_initialpaths_for_relpath(session, fspath):

This comment has been minimized.

Copy link
Member Author

@RonnyPfannschmidt RonnyPfannschmidt commented Mar 10, 2018

one of the reasons is that it makes introduction of new nodes and note types much more painful
in future i think we need to change how nodes are constructed, the smart ctors where a massive mistake that makes structural change a hazard (i need various new types of nodes to express marks in parametrization sanely)

the other thing is that that we basically had a critical value for node identification generated "magically at a distance" - thats just rotten bad engineering

@nicoddemus nicoddemus merged commit 0557ab4 into pytest-dev:features Mar 12, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build passed
@RonnyPfannschmidt RonnyPfannschmidt deleted the RonnyPfannschmidt:small-moves branch Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants