Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove CmdOptions since we can use argparse.Namespace() #3304

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Mar 13, 2018

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
just a guideline):

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Add yourself to AUTHORS in alphabetical order;

@RonnyPfannschmidt RonnyPfannschmidt force-pushed the RonnyPfannschmidt:cmdoptions-removal branch from b1dd649 to 87f2003 Mar 13, 2018

@RonnyPfannschmidt RonnyPfannschmidt requested a review from nicoddemus Mar 13, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 13, 2018

Coverage Status

Coverage increased (+0.05%) to 92.961% when pulling 87f2003 on RonnyPfannschmidt:cmdoptions-removal into f8791c9 on pytest-dev:features.

@nicoddemus
Copy link
Member

nicoddemus left a comment

Great, thanks!

@nicoddemus nicoddemus merged commit cbb2c55 into pytest-dev:features Mar 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RonnyPfannschmidt RonnyPfannschmidt deleted the RonnyPfannschmidt:cmdoptions-removal branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.