Fix issue #3372 #3373
Fix issue #3372 #3373
Conversation
_pytest/python_api.py
Outdated
| " derived from BaseException, not %s") | ||
| raise TypeError(msg % type(exc)) | ||
| if not isclass(expected_exception) or not issubclass(expected_exception, BaseException): | ||
| for exc in filterfalse(isclass, always_iterable(expected_exception)): |
There was a problem hiding this comment.
please try using base_type=type
There was a problem hiding this comment.
oh, that sounds nice! just a moment.
There was a problem hiding this comment.
just to be clear: do you want base_type=type or base_type=(type, six.text_type, six.binary_type)?
There was a problem hiding this comment.
i beleive the shorter variant is sufficient, please try ^^
There was a problem hiding this comment.
it works in both variants. :)
upon further inspection, i'd prefer the longer variant as i believe it to lead to nicer error messages as strings don't get split into individual characters.
base_type = (type, text_type, binary_type)
for exc in filterfalse(isclass, always_iterable(expected_exception, base_type)):
msg = ("exceptions must be old-style classes or"
" derived from BaseException, not %s")
raise TypeError(msg % type(exc))however, please feel free to modify the PR to your liking. ^^
There was a problem hiding this comment.
and (sorry for the many messages): thank you for reviewing and commenting! it's greatly appreciated. :D
There was a problem hiding this comment.
you are doing great work 👍
_pytest/python_api.py
Outdated
| msg = ("exceptions must be old-style classes or" | ||
| " derived from BaseException, not %s") | ||
| " derived from BaseException, not %s") |
There was a problem hiding this comment.
this one is the unfortunate dedent mistake that broke the linting job ^^
|
Awesome contribution @backbord, thanks a lot. Expect it to be published in the next bug-fix release. 😁 |
|
Sent an invitation to @backbord as our policy. |
Add bugfix and test for #3372: Exception classes may have a type that looks iterable which caused problems with
pytest.raises.Unfortunately, I wasn't able to use
base_typeas proposed by Ronny:pytest.raisesis passed an exception class and I didn't find a way around callingissubclass.Only tested in py3.6.
Not a regular contributer, so I hope everything is up to speed and in accordance with your guidelines.