Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Node: do not add "::()" to nodeid #4358
referenced this pull request
Nov 9, 2018
@@ Coverage Diff @@ ## features #4358 +/- ## ============================================ + Coverage 95.84% 95.84% +<.01% ============================================ Files 111 111 Lines 24927 24928 +1 Branches 2436 2438 +2 ============================================ + Hits 23891 23892 +1 Misses 737 737 Partials 299 299
Great work, we only need a "removal" changelog entry. Given that this is a removal without a deprecation period (because it is not possible to add a deprecation to it) we should explain it in detail. I suggest something along these lines:
Remove the ``::()`` notation to denote test class instances in node ids. Previously, node ids that contain test instances would use ``::()`` to denote the instance like this:: test_foo.py::Test::()::test_bar The extra ```::()`` was puzzling to most users and has been removed, so that test id is now:: test_foo.py::Test::test_bar This change could not accompany a deprecation period as is usual when user-facing functionality changes because it was not really possible to detect when the functionality was being used explicitly.