Join GitHub today
Remove terminal_reporter workaround from logging.py #4741
The workaround was removed from the logging module by creating python
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs (you can delete this text from the final description, this is
Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
Please add a "trivial" CHANGELOG entry that those internal attributes are now read-only properties.
Hmmm this might break some code which was changing those properties. Of course that code would probably be working by accident like we saw was the case of the changes on the logging module.
Seems as if
converting the read only properties to a read/write properties is unfortunately not as obvious as it may seem, since setting showfspath must not change the value of e.g. showheader.
What do you think about my fix for this? (If all tests pass I'll also add setter properties for the other show properties, but not for verbosity.