Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display number of different items with sequence/dict comparisons #5026

Merged
merged 4 commits into from Apr 5, 2019

Conversation

Projects
None yet
3 participants
@blueyed
Copy link
Contributor

commented Apr 2, 2019

TODO:

  • tests
@codecov

This comment has been minimized.

Copy link

commented Apr 2, 2019

Codecov Report

Merging #5026 into features will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5026      +/-   ##
============================================
+ Coverage     96.07%   96.07%   +<.01%     
============================================
  Files           114      114              
  Lines         25778    25811      +33     
  Branches       2552     2554       +2     
============================================
+ Hits          24765    24798      +33     
  Misses          704      704              
  Partials        309      309
Impacted Files Coverage Δ
testing/test_assertion.py 97.67% <100%> (+0.04%) ⬆️
src/_pytest/assertion/util.py 97.77% <100%> (+0.11%) ⬆️
testing/test_cacheprovider.py 99.73% <0%> (ø) ⬆️
src/_pytest/cacheprovider.py 97.64% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04936f...0f965e5. Read the comment docs.

@blueyed

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Wow, really no failing tests..

@nicoddemus

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Wow, really no failing tests..

😞

Well we should definitely add some then.

@nicoddemus

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Otherwise the code looks good! 👍

@blueyed blueyed requested a review from asottile Apr 3, 2019

@asottile
Copy link
Member

left a comment

looks good, let's add some sanity tests to cover the cases and then shipit! 👍

@blueyed blueyed force-pushed the blueyed:compare-len-diff branch from b7b44e1 to 47d92a0 Apr 4, 2019

@blueyed

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

Added tests, and improved the messages a bit more (for single items).

@nicoddemus

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

LGTM, only missing CHANGELOG. 👍

@blueyed

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

Added changelog, fixed branch coverage.

@nicoddemus nicoddemus merged commit 4f33f46 into pytest-dev:features Apr 5, 2019

5 checks passed

WIP Ready for review
Details
codecov/patch 100% of diff hit (target 96.07%)
Details
codecov/project 96.07% (+<.01%) compared to e04936f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pytest-CI #20190405.9 succeeded
Details
@nicoddemus

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.