Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-last-failure: improve reporting #5034

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@blueyed
Copy link
Contributor

commented Apr 3, 2019

No description provided.

@blueyed blueyed force-pushed the blueyed:run-last-failure-report branch 2 times, most recently from 138d476 to 9ca4411 Apr 3, 2019

@blueyed blueyed marked this pull request as ready for review Apr 3, 2019

@blueyed blueyed force-pushed the blueyed:run-last-failure-report branch from 9ca4411 to 1f5a61e Apr 3, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 3, 2019

Codecov Report

Merging #5034 into features will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5034      +/-   ##
============================================
+ Coverage     96.06%   96.06%   +<.01%     
============================================
  Files           114      114              
  Lines         25749    25752       +3     
  Branches       2550     2549       -1     
============================================
+ Hits          24736    24739       +3     
  Misses          704      704              
  Partials        309      309
Impacted Files Coverage Δ
src/_pytest/cacheprovider.py 97.6% <100%> (+0.01%) ⬆️
testing/test_cacheprovider.py 99.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1410d3d...1f5a61e. Read the comment docs.

# only outside of it.
self._report_status = "%d known failures not in selected tests" % (
len(self.lastfailed),
)

This comment has been minimized.

Copy link
@blueyed

blueyed Apr 3, 2019

Author Contributor

This could have a hint to use --cache-show cache/lastfailed to see them (with #5035).

(I am having a lot there from files that do not exist anymore etc - it could also have an improved message for when no args are passed really then)

This comment has been minimized.

Copy link
@nicoddemus

nicoddemus Apr 3, 2019

Member

If it doesn't get too verbose, I'm fine with it. Up to you. 👍

This comment has been minimized.

Copy link
@blueyed

blueyed Apr 3, 2019

Author Contributor

Maybe / rather in a followup.

@blueyed blueyed requested review from dhirensr and brianmaissy Apr 3, 2019

@nicoddemus
Copy link
Member

left a comment

LGTM! 👍

@blueyed blueyed merged commit 0d4636b into pytest-dev:features Apr 3, 2019

5 checks passed

WIP Ready for review
Details
codecov/patch 100% of diff hit (target 96.06%)
Details
codecov/project 96.06% (+<.01%) compared to 1410d3d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pytest-CI #20190403.18 succeeded
Details

@blueyed blueyed deleted the blueyed:run-last-failure-report branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.