Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support glob argument with ``--cache-show`` #5035

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
2 participants
@blueyed
Copy link
Contributor

commented Apr 3, 2019

TODO:

  • changelog

@blueyed blueyed force-pushed the blueyed:cache-glob branch from c6fea14 to 0723685 Apr 3, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 3, 2019

Codecov Report

Merging #5035 into features will decrease coverage by 1.15%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5035      +/-   ##
============================================
- Coverage     96.07%   94.91%   -1.16%     
============================================
  Files           114      114              
  Lines         25778    25780       +2     
  Branches       2552     2553       +1     
============================================
- Hits          24765    24468     -297     
- Misses          704      991     +287     
- Partials        309      321      +12
Impacted Files Coverage Δ
testing/test_cacheprovider.py 97.06% <100%> (-2.67%) ⬇️
src/_pytest/cacheprovider.py 97.64% <71.42%> (+0.03%) ⬆️
testing/test_argcomplete.py 20.28% <0%> (-47.83%) ⬇️
src/_pytest/_argcomplete.py 33.33% <0%> (-41.67%) ⬇️
testing/test_conftest.py 90.33% <0%> (-9.3%) ⬇️
testing/test_pathlib.py 91.17% <0%> (-8.83%) ⬇️
src/_pytest/pytester.py 85.65% <0%> (-5.53%) ⬇️
testing/test_collection.py 95.29% <0%> (-4.52%) ⬇️
src/_pytest/reports.py 90.5% <0%> (-4.5%) ⬇️
testing/test_tmpdir.py 94.62% <0%> (-4.31%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04936f...eb5b2e0. Read the comment docs.

@nicoddemus
Copy link
Member

left a comment

Please mention this new feature in the "Inspecting Cache content" in cache.rst. 👍

Show resolved Hide resolved src/_pytest/cacheprovider.py

@blueyed blueyed force-pushed the blueyed:cache-glob branch from 0723685 to 10c57f5 Apr 4, 2019

@blueyed blueyed requested a review from nicoddemus Apr 4, 2019

@blueyed blueyed force-pushed the blueyed:cache-glob branch from 10c57f5 to eb5b2e0 Apr 4, 2019

@nicoddemus

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Great work! 👍

@blueyed blueyed merged commit 8ad99c5 into pytest-dev:features Apr 5, 2019

5 checks passed

WIP Ready for review
Details
codecov/patch 100% of diff hit (target 96.07%)
Details
codecov/project 96.07% (+<.01%) compared to e04936f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pytest-CI #20190404.16 succeeded
Details

@blueyed blueyed deleted the blueyed:cache-glob branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.