Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytester: allow passing in stdin to run/popen #5059

Merged
merged 5 commits into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@blueyed
Copy link
Contributor

commented Apr 6, 2019

This makes it more flexible to use testdir.run / testdir.popen.

Show resolved Hide resolved src/_pytest/pytester.py Outdated
@codecov

This comment has been minimized.

Copy link

commented Apr 6, 2019

Codecov Report

Merging #5059 into features will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5059      +/-   ##
============================================
+ Coverage     96.07%   96.08%   +0.01%     
============================================
  Files           114      114              
  Lines         25823    25868      +45     
  Branches       2554     2559       +5     
============================================
+ Hits          24810    24856      +46     
  Misses          704      704              
+ Partials        309      308       -1
Impacted Files Coverage Δ
src/_pytest/pytester.py 91.32% <100%> (+0.15%) ⬆️
testing/test_pytester.py 89.3% <100%> (+1.01%) ⬆️
testing/test_pdb.py 99.2% <0%> (ø) ⬆️
src/_pytest/debugging.py 89.41% <0%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b549438...b84f826. Read the comment docs.

@blueyed blueyed force-pushed the blueyed:pytester-popen-run-stdin branch from 0bbcfe8 to e2ceb25 Apr 6, 2019

@blueyed blueyed force-pushed the blueyed:pytester-popen-run-stdin branch from e2ceb25 to 4fca86e Apr 6, 2019

@blueyed blueyed requested a review from altendky Apr 9, 2019

@nicoddemus
Copy link
Member

left a comment

Great job! Please take a look at my comments, other than that looks good. 👍

Show resolved Hide resolved src/_pytest/pytester.py Outdated
Show resolved Hide resolved src/_pytest/pytester.py Outdated
Show resolved Hide resolved testing/test_pytester.py

@blueyed blueyed merged commit 10fa66e into pytest-dev:features Apr 10, 2019

4 of 5 checks passed

pytest-CI #20190409.2 failed
Details
WIP Ready for review
Details
codecov/patch 100% of diff hit (target 96.07%)
Details
codecov/project 96.08% (+0.01%) compared to b549438
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@blueyed blueyed deleted the blueyed:pytester-popen-run-stdin branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.