Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reportchars=A (`-rA`) #5068

Merged
merged 4 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@blueyed
Copy link
Contributor

commented Apr 7, 2019

TODO:

  • changelog, docs

@blueyed blueyed changed the base branch from master to features Apr 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 7, 2019

Codecov Report

Merging #5068 into features will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5068      +/-   ##
============================================
+ Coverage     96.07%   96.09%   +0.01%     
============================================
  Files           114      115       +1     
  Lines         25823    25894      +71     
  Branches       2554     2560       +6     
============================================
+ Hits          24810    24883      +73     
  Misses          704      704              
+ Partials        309      307       -2
Impacted Files Coverage Δ
src/_pytest/terminal.py 92.83% <100%> (+0.37%) ⬆️
testing/test_terminal.py 99.82% <100%> (ø) ⬆️
testing/test_skipping.py 97.47% <0%> (-0.18%) ⬇️
testing/test_modimport.py 100% <0%> (ø) ⬆️
testing/test_capture.py 99.24% <0%> (ø) ⬆️
testing/conftest.py 100% <0%> (ø)
testing/test_pdb.py 99.2% <0%> (ø) ⬆️
src/_pytest/pytester.py 91.39% <0%> (+0.22%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b549438...42e60d9. Read the comment docs.

@blueyed blueyed requested a review from asottile Apr 9, 2019

@asottile
Copy link
Member

left a comment

@asottile

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

needs a changelog entry, also if there's docs to update

@blueyed

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

Added doc/changelog.

Show resolved Hide resolved src/_pytest/terminal.py
Show resolved Hide resolved changelog/5068.feature.rst

@nicoddemus nicoddemus merged commit 19035f4 into pytest-dev:features Apr 12, 2019

5 checks passed

WIP Ready for review
Details
codecov/patch 100% of diff hit (target 96.07%)
Details
codecov/project 96.09% (+0.01%) compared to b549438
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pytest-CI #20190411.7 succeeded
Details

@blueyed blueyed deleted the blueyed:reportchars branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.