Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytester: improve/fix kwargs validation #5082

Merged
merged 3 commits into from Apr 10, 2019

Conversation

Projects
None yet
2 participants
@blueyed
Copy link
Contributor

commented Apr 10, 2019

No description provided.

@blueyed blueyed force-pushed the blueyed:pytester-raise_on_kwargs branch from 233d29b to 148f2fc Apr 10, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 10, 2019

Codecov Report

Merging #5082 into features will decrease coverage by 4.68%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           features   #5082      +/-   ##
===========================================
- Coverage     96.09%   91.4%   -4.69%     
===========================================
  Files           115     115              
  Lines         25889   25895       +6     
  Branches       2563    2425     -138     
===========================================
- Hits          24877   23670    -1207     
- Misses          704    1807    +1103     
- Partials        308     418     +110
Impacted Files Coverage Δ
testing/test_capture.py 94.43% <100%> (-4.82%) ⬇️
src/_pytest/pytester.py 84.48% <90.9%> (-6.84%) ⬇️
testing/test_pdb.py 40% <0%> (-59.21%) ⬇️
testing/test_argcomplete.py 20.28% <0%> (-47.83%) ⬇️
src/_pytest/_argcomplete.py 33.33% <0%> (-41.67%) ⬇️
src/_pytest/compat.py 77.88% <0%> (-19.1%) ⬇️
src/_pytest/debugging.py 70.37% <0%> (-19.05%) ⬇️
src/_pytest/unittest.py 75.66% <0%> (-18.52%) ⬇️
testing/code/test_excinfo.py 83.16% <0%> (-13.64%) ⬇️
testing/test_unittest.py 85.58% <0%> (-13.52%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10fa66e...12133d4. Read the comment docs.

@blueyed

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

@@ -1213,7 +1220,7 @@ def runpytest_subprocess(self, *args, **kwargs):
if plugins:
args = ("-p", plugins[0]) + args
args = self._getpytestargs() + args
return self.run(*args, timeout=kwargs.get("timeout"))
return self.run(*args, timeout=timeout)

This comment has been minimized.

Copy link
@blueyed

blueyed Apr 10, 2019

Author Contributor

Note that this test only works accidentally, and is not testing the original issue anymore (see #5084), but that should not hold this PR back.

@nicoddemus
Copy link
Member

left a comment

Thanks!

@blueyed blueyed merged commit b375937 into pytest-dev:features Apr 10, 2019

2 of 4 checks passed

codecov/patch 91.66% of diff hit (target 96.09%)
Details
codecov/project 91.4% (-4.69%) compared to 10fa66e
Details
WIP Ready for review
Details
pytest-CI #20190410.6 succeeded
Details

@blueyed blueyed deleted the blueyed:pytester-raise_on_kwargs branch Apr 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.