Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal summary: display passes after warnings #5108

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@blueyed
Copy link
Contributor

commented Apr 14, 2019

This displays passes (with output, -rP) before the short summary, and
before any other output from other plugins also.

TODO:

  • changelog, test
@nicoddemus
Copy link
Member

left a comment

Please also add a test and CHANGELOG. 👍

@codecov

This comment has been minimized.

Copy link

commented Apr 14, 2019

Codecov Report

Merging #5108 into features will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5108      +/-   ##
============================================
+ Coverage      96.1%   96.13%   +0.03%     
============================================
  Files           115      115              
  Lines         25927    26090     +163     
  Branches       2566     2654      +88     
============================================
+ Hits          24916    25081     +165     
- Misses          704      707       +3     
+ Partials        307      302       -5
Impacted Files Coverage Δ
src/_pytest/terminal.py 92.88% <100%> (+0.01%) ⬆️
testing/test_terminal.py 99.82% <100%> (-0.01%) ⬇️
src/_pytest/cacheprovider.py 97.7% <0%> (+0.06%) ⬆️
src/_pytest/config/__init__.py 95.8% <0%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b904a...ea79eb5. Read the comment docs.

terminal summary: display passes after warnings
This displays passes (with output, `-rP`) before the short summary, and
before any other output from other plugins also.

@blueyed blueyed force-pushed the blueyed:summary branch from 51d4617 to ea79eb5 Apr 15, 2019

@nicoddemus nicoddemus merged commit b64d940 into pytest-dev:features Apr 15, 2019

5 checks passed

WIP Ready for review
Details
codecov/patch 100% of diff hit (target 96.1%)
Details
codecov/project 96.13% (+0.03%) compared to c8b904a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pytest-CI #20190415.12 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.