Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal: use pytest_collection_finish for reporting #5113

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
None yet
2 participants
@blueyed
Copy link
Contributor

commented Apr 14, 2019

This is required to report deselected items from other hookwrappers.

@blueyed blueyed force-pushed the blueyed:terminal-hookwrapper branch from 116af9f to 48e13a0 Apr 14, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 14, 2019

Codecov Report

Merging #5113 into features will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5113      +/-   ##
============================================
+ Coverage     96.09%   96.12%   +0.03%     
============================================
  Files           115      115              
  Lines         26007    26012       +5     
  Branches       2566     2566              
============================================
+ Hits          24991    25004      +13     
+ Misses          713      706       -7     
+ Partials        303      302       -1
Impacted Files Coverage Δ
src/_pytest/terminal.py 93.09% <100%> (-0.02%) ⬇️
testing/test_terminal.py 99.83% <100%> (ø) ⬆️
testing/acceptance_test.py 98.04% <0%> (+0.39%) ⬆️
src/_pytest/doctest.py 96.41% <0%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 766fc23...ff5317a. Read the comment docs.

@blueyed blueyed changed the title terminal: pytest_collection_modifyitems: use hookwrapper terminal: use pytest_collection_finish for reporting Apr 14, 2019

@blueyed blueyed requested review from nicoddemus and asottile Apr 20, 2019

@nicoddemus
Copy link
Member

left a comment

Thanks @blueyed!

The solution looks good, only problem is that I don't think the test is reproducing the issue correctly. Can you take a look? Thanks!

Show resolved Hide resolved testing/test_terminal.py

@blueyed blueyed force-pushed the blueyed:terminal-hookwrapper branch from 48e13a0 to ff5317a Apr 29, 2019

@blueyed blueyed requested a review from nicoddemus Apr 29, 2019

@nicoddemus

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Thanks!

@nicoddemus nicoddemus merged commit fb6dad6 into pytest-dev:features Apr 29, 2019

5 checks passed

WIP Ready for review
Details
codecov/patch 100% of diff hit (target 96.09%)
Details
codecov/project 96.12% (+0.03%) compared to 766fc23
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pytest-CI #20190429.2 succeeded
Details

@blueyed blueyed deleted the blueyed:terminal-hookwrapper branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.