Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest_sessionfinish: preset exitstatus with UsageErrors #5144

Merged
merged 2 commits into from Apr 19, 2019

Conversation

Projects
None yet
2 participants
@blueyed
Copy link
Contributor

commented Apr 18, 2019

Previously it would be 0. Setting it to the expected outcome
(EXIT_USAGEERROR) here already helps pytest_sessionfinish hooks.

TODO:

  • changelog
pytest_sessionfinish: preset exitstatus with UsageErrors
Previously it would be 0.  Setting it to the expected outcome
(EXIT_USAGEERROR) here already helps `pytest_sessionfinish` hooks.

@blueyed blueyed added the type: bug label Apr 18, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 18, 2019

Codecov Report

Merging #5144 into features will decrease coverage by 4.8%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5144      +/-   ##
============================================
- Coverage     96.11%   91.31%   -4.81%     
============================================
  Files           115      115              
  Lines         25926    25930       +4     
  Branches       2563     2425     -138     
============================================
- Hits          24919    23677    -1242     
- Misses          704     1843    +1139     
- Partials        303      410     +107
Impacted Files Coverage Δ
testing/acceptance_test.py 89.45% <100%> (-8.59%) ⬇️
src/_pytest/main.py 94.51% <100%> (-1.53%) ⬇️
testing/test_pdb.py 40% <0%> (-59.21%) ⬇️
testing/test_argcomplete.py 20.28% <0%> (-47.83%) ⬇️
src/_pytest/_argcomplete.py 33.33% <0%> (-41.67%) ⬇️
testing/python/approx.py 80.45% <0%> (-19.18%) ⬇️
src/_pytest/compat.py 77.88% <0%> (-19.1%) ⬇️
src/_pytest/debugging.py 70.37% <0%> (-19.05%) ⬇️
src/_pytest/unittest.py 75.66% <0%> (-18.52%) ⬇️
testing/code/test_excinfo.py 83.16% <0%> (-13.64%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1460ad6...4749dca. Read the comment docs.

@blueyed blueyed merged commit 79d5fc3 into pytest-dev:features Apr 19, 2019

4 checks passed

WIP Ready for review
Details
codecov/patch 100% of diff hit (target 96.11%)
Details
codecov/project Absolute coverage decreased by -4.8% but relative coverage increased by +3.88% compared to 1460ad6
Details
pytest-CI #20190418.2 succeeded
Details

@blueyed blueyed deleted the blueyed:sessionfinish-exitstatus branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.