Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: Extend LEVELNAME_FMT_REGEX #5335

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
3 participants
@thisch
Copy link
Contributor

commented May 29, 2019

The reason why I've added support for truncated fixed with alignment of the levelname is saving horizontal space by using, e.g., '%(levelname).1s'.

  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Target the features branch for new features and removals/deprecations.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Add yourself to AUTHORS in alphabetical order;
@thisch

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Note that the CI errors are not related to the changes in this PR.

@thisch thisch force-pushed the thisch:fmtregex branch 2 times, most recently from ed129b4 to e078df2 May 31, 2019

@codecov

This comment has been minimized.

Copy link

commented May 31, 2019

Codecov Report

Merging #5335 into master will decrease coverage by 37.35%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5335       +/-   ##
===========================================
- Coverage   94.41%   57.06%   -37.36%     
===========================================
  Files         115       56       -59     
  Lines       25895    11083    -14812     
  Branches     2496     2049      -447     
===========================================
- Hits        24450     6324    -18126     
- Misses       1128     4078     +2950     
- Partials      317      681      +364
Impacted Files Coverage Δ
src/_pytest/logging.py 53.77% <100%> (-41.51%) ⬇️
src/_pytest/helpconfig.py 26.4% <0%> (-71.2%) ⬇️
src/_pytest/junitxml.py 26.17% <0%> (-69.71%) ⬇️
src/_pytest/unittest.py 25.96% <0%> (-69.07%) ⬇️
src/_pytest/debugging.py 23.58% <0%> (-66.67%) ⬇️
src/_pytest/mark/legacy.py 32% <0%> (-66%) ⬇️
src/_pytest/mark/evaluate.py 32.96% <0%> (-63.74%) ⬇️
src/_pytest/pastebin.py 25.8% <0%> (-62.91%) ⬇️
src/_pytest/setuponly.py 34% <0%> (-62%) ⬇️
src/_pytest/stepwise.py 36.66% <0%> (-60%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ac469...ef05319. Read the comment docs.

@thisch thisch requested review from nicoddemus and blueyed May 31, 2019

@nicoddemus
Copy link
Member

left a comment

LGTM,

Now that 4.6 is out, could this be considered a bug fix then instead, as it handles a feature not released by the time the PR was opened? 🤔

@thisch

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Yes, I think it makes sense to consider it as a bug fix instead. Which branch do I have to target now, still master or the 4.6-maintenance branch?

@thisch thisch force-pushed the thisch:fmtregex branch from e078df2 to 578c3b2 Jun 3, 2019

@thisch thisch changed the base branch from features to master Jun 3, 2019

@thisch thisch force-pushed the thisch:fmtregex branch from 578c3b2 to ef05319 Jun 3, 2019

@thisch

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

I've rebased it on top of master and updated the changelog filename.
LGTM

@thisch thisch merged commit b8781ff into pytest-dev:master Jun 3, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
pytest-CI in progress
Details
WIP Ready for review
Details
@thisch

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

I've just added the needs backport label, I hope that this is fine.

@nicoddemus

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Technically this is a new feature, so it shouldn't go into the 4.6 series.

@blueyed blueyed removed the needs backport label Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.