Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the scope behavior with indirect fixtures #5798

Merged
merged 2 commits into from Aug 30, 2019
Merged

Fix the scope behavior with indirect fixtures #5798

merged 2 commits into from Aug 30, 2019

Conversation

aklajnert
Copy link
Contributor

Resolves #570

Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash and force-push then.

@aklajnert
Copy link
Contributor Author

@blueyed done.

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @aklajnert! This was a very long standing issue, glad someone took the time to fix it. 😁

I took the liberty of improving the changelog a bit and write the test in a way that IMHO is easier to follow and debug if it breaks in the future. Let me know if you don't agree with the changes. 👍

@aklajnert
Copy link
Contributor Author

Thanks @nicoddemus, indeed - your test is much more straightforward. I had a few approaches for writing the test for it - mostly to reproduce the bug, but your solution is better.

@nicoddemus
Copy link
Member

Cool!

Merging then, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

indirect=True in parametrize breaks fixture scopes
3 participants