testing: fix pexpect hang #7937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the tests work when running with PYTHONPYCACHEPREFIX (possible when running in a dirty environment, not under tox).
Part of investigating a bug, but didn't fix it.
bluetech
force-pushed
the
testing-fixes
branch
from
02c2ba7 to
4da5166
Compare
In pytester tests, pytest stashes & restores the sys.modules for each test. So if the test imports a new module, it is initialized anew each time. Turns out the readline module isn't multi-init safe, which causes pytester.spawn to crash or hang. So preserve it as a workaround.
bluetech
force-pushed
the
testing-fixes
branch
from
4da5166 to
ca82214
Compare
Member
Author
|
I'll merge already to fix the broken CI, but let me know if there are any further comments. |
Member
|
Awesome, thanks @bluetech! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7913 (hopefully). There are some other commits I made to testing while debugging this but they are not critical.