New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify error message in case no collectors are found for a file #9823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Not sure if such an almost-trivial change warrants an a changelog and authors entry.
I think so, improvements (however small) are worthy of note.
Plus we need a test for the change, specially to ensure it doesn't regress.
Thanks for the feedback. I've now added a changelog and authors entry, and fixed the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
@tobiasdiez - you'll need to merge in |
Thanks, that worked like a charm! |
Thank you for the patch! Good error messages are enormously important to users, but so often neglected - it's a tricky form of "expert blindness" which makes contributions especially valuable |
In case no collector is found for a given file (e.g. if you run
pytest something.unrecognized
), then the somewhat cryptic error messageWith this PR, a more meaningful error message is displayed.
Not sure if such an almost-trivial change warrants an a changelog and authors entry.