From cdf837f3c425f8189d7195208c2c21290a143a6f Mon Sep 17 00:00:00 2001 From: Alexandru Cambose Date: Sun, 21 Sep 2025 22:13:23 +0100 Subject: [PATCH 1/6] fix: sidebar positioning --- .../Root/fumadocs-global-style-overrides.css | 11 +++++++++++ .../component-library/src/AppShell/index.module.scss | 5 +---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css b/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css index e39f49dbdb..385dade52b 100644 --- a/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css +++ b/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css @@ -26,4 +26,15 @@ Overrides for Fumadocs content. Everything after prose is MDX generated content #nd-sidebar { --fd-sidebar-top: var(--header-height) !important; + position: sticky !important; + height: calc(100vh - var(--header-height)); } + +#nd-docs-layout { + flex-direction: row !important; + padding-inline-start: 0 !important; +} + +#nd-toc { + top: calc(var(--header-height) + 1rem) !important; +} \ No newline at end of file diff --git a/packages/component-library/src/AppShell/index.module.scss b/packages/component-library/src/AppShell/index.module.scss index dc42e1ee6b..a51e9d0e7b 100644 --- a/packages/component-library/src/AppShell/index.module.scss +++ b/packages/component-library/src/AppShell/index.module.scss @@ -14,7 +14,6 @@ } .body { - background: black; -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale; scroll-behavior: smooth; @@ -33,9 +32,7 @@ background: theme.color("background", "primary"); border-top-left-radius: calc(var(--offset) * theme.border-radius("xl")); border-top-right-radius: calc(var(--offset) * theme.border-radius("xl")); - overflow: hidden auto; - transform: scale(calc(100% - (var(--offset) * 5%))); - height: 100dvh; + min-height: 100dvh; scrollbar-gutter: stable; .header { From ea5ddecde063ec09b04706394587195fb20f9314 Mon Sep 17 00:00:00 2001 From: Alexandru Cambose Date: Mon, 22 Sep 2025 19:05:33 +0100 Subject: [PATCH 2/6] revert --- packages/component-library/src/AppShell/index.module.scss | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/component-library/src/AppShell/index.module.scss b/packages/component-library/src/AppShell/index.module.scss index a51e9d0e7b..6186ef3e97 100644 --- a/packages/component-library/src/AppShell/index.module.scss +++ b/packages/component-library/src/AppShell/index.module.scss @@ -14,6 +14,7 @@ } .body { + background: black; -webkit-font-smoothing: antialiased; -moz-osx-font-smoothing: grayscale; scroll-behavior: smooth; @@ -32,7 +33,9 @@ background: theme.color("background", "primary"); border-top-left-radius: calc(var(--offset) * theme.border-radius("xl")); border-top-right-radius: calc(var(--offset) * theme.border-radius("xl")); - min-height: 100dvh; + height: 100dvh; + overflow: hidden auto; + transform: scale(calc(100% - (var(--offset) * 5%))); scrollbar-gutter: stable; .header { From 5e2960f1511421d393efb7638cba06fac5f94a5c Mon Sep 17 00:00:00 2001 From: Alexandru Cambose Date: Mon, 22 Sep 2025 19:51:29 +0100 Subject: [PATCH 3/6] fix toc --- .../Root/fumadocs-global-style-overrides.css | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css b/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css index 385dade52b..e359d75d4a 100644 --- a/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css +++ b/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css @@ -37,4 +37,12 @@ Overrides for Fumadocs content. Everything after prose is MDX generated content #nd-toc { top: calc(var(--header-height) + 1rem) !important; -} \ No newline at end of file + height: max-content; + position: sticky; + margin-left: calc(-1 * var(--fd-toc-width)); +} + +#nd-toc > div { + position: relative; + left: var(--fd-toc-width); +} From eeb1d16c44d780582297c04a732c4919d232e839 Mon Sep 17 00:00:00 2001 From: Alexandru Cambose Date: Mon, 22 Sep 2025 19:53:40 +0100 Subject: [PATCH 4/6] comment --- .../src/components/Root/fumadocs-global-style-overrides.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css b/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css index e359d75d4a..effe6136a1 100644 --- a/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css +++ b/apps/developer-hub/src/components/Root/fumadocs-global-style-overrides.css @@ -35,8 +35,9 @@ Overrides for Fumadocs content. Everything after prose is MDX generated content padding-inline-start: 0 !important; } +/* Hacky fix to get the TOC to be sticky */ #nd-toc { - top: calc(var(--header-height) + 1rem) !important; + top: var(--header-height) !important; height: max-content; position: sticky; margin-left: calc(-1 * var(--fd-toc-width)); From 76a95e72b724195eabbaa1df212837371e20cf1e Mon Sep 17 00:00:00 2001 From: Alexandru Cambose Date: Mon, 22 Sep 2025 20:05:29 +0100 Subject: [PATCH 5/6] feat: use portal for search --- .../developer-hub/src/components/search-button.tsx | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/apps/developer-hub/src/components/search-button.tsx b/apps/developer-hub/src/components/search-button.tsx index f02e978860..f89d186f38 100644 --- a/apps/developer-hub/src/components/search-button.tsx +++ b/apps/developer-hub/src/components/search-button.tsx @@ -3,6 +3,7 @@ import { SearchButton as SearchButtonComponent } from "@pythnetwork/component-library/SearchButton"; import DefaultSearchDialog from "fumadocs-ui/components/dialog/search-default"; import { useCallback, useState } from "react"; +import { createPortal } from "react-dom"; export const SearchButton = () => { const [open, setOpen] = useState(false); @@ -19,11 +20,14 @@ export const SearchButton = () => { largeScreenContent="Search" onClick={handleSearch} /> - + {open && createPortal( + , + document.body + )} ); }; From 6610d9fed8f3d7c952c41680ad500902547a8863 Mon Sep 17 00:00:00 2001 From: Alexandru Cambose Date: Mon, 22 Sep 2025 20:11:20 +0100 Subject: [PATCH 6/6] formatting --- .../src/components/search-button.tsx | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/apps/developer-hub/src/components/search-button.tsx b/apps/developer-hub/src/components/search-button.tsx index f89d186f38..9f8aa6174c 100644 --- a/apps/developer-hub/src/components/search-button.tsx +++ b/apps/developer-hub/src/components/search-button.tsx @@ -20,14 +20,15 @@ export const SearchButton = () => { largeScreenContent="Search" onClick={handleSearch} /> - {open && createPortal( - , - document.body - )} + {open && + createPortal( + , + document.body, + )} ); };