From 2afbcb2f94df503950bedc057ded1d963ac78520 Mon Sep 17 00:00:00 2001 From: Micael Jarniac Date: Thu, 7 Apr 2022 01:38:46 -0300 Subject: [PATCH] Remove mutable default arg in function example (#944) * Remove mutable default arg in function example Removed mutable default arg, replaced with `None`. https://docs.quantifiedcode.com/python-anti-patterns/correctness/mutable_default_value_as_argument.html Replaced `dict()` with `{}`. https://stackoverflow.com/questions/8424942/creating-a-new-dictionary-in-python * Wrong import * Undo last commit My bad. Co-authored-by: Hynek Schlawack --- docs/extending.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/extending.rst b/docs/extending.rst index 2fb2aa0b9..d5775adcc 100644 --- a/docs/extending.rst +++ b/docs/extending.rst @@ -176,10 +176,10 @@ Here are some tips for effective use of metadata: >>> >>> def typed( ... cls, default=NOTHING, validator=None, repr=True, - ... eq=True, order=None, hash=None, init=True, metadata={}, + ... eq=True, order=None, hash=None, init=True, metadata=None, ... converter=None ... ): - ... metadata = dict() if not metadata else metadata + ... metadata = metadata or {} ... metadata[MY_TYPE_METADATA] = cls ... return field( ... default=default, validator=validator, repr=repr,