Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor stub issues #1072

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Fix minor stub issues #1072

merged 1 commit into from
Dec 20, 2022

Conversation

hynek
Copy link
Member

@hynek hynek commented Dec 20, 2022

I've tried running ruff over attrs and these issues seem legit.

@hynek hynek requested a review from Tinche December 20, 2022 10:07
@hynek
Copy link
Member Author

hynek commented Dec 20, 2022

uh what's with the checks? did i screw something up when adding environments to the deploy stuff? @webknjaz? 😇

https://www.githubstatus.com says all is dandy

@hynek hynek closed this Dec 20, 2022
@hynek hynek reopened this Dec 20, 2022
@hynek hynek enabled auto-merge (squash) December 20, 2022 14:09
@hynek hynek merged commit b9f35eb into main Dec 20, 2022
@hynek hynek deleted the stub-issues branch December 20, 2022 14:10
@webknjaz
Copy link
Member

webknjaz commented Dec 20, 2022

uh what's with the checks? did i screw something up when adding environments to the deploy stuff? @webknjaz? innocent

githubstatus.com says all is dandy

I haven't seen what was happening when you tagged me, but sometimes GitHub is just drunk. Their eventually consistent event delivery system sometimes fails to propagate events and doesn't re-deliver them after having platform troubles ("by design").
It's also worth noting that GitHub doesn't always update the status website. Sometimes there are issues with GHA or unicorns that are short-lasting and that doesn't end up on the status page.
Looking at https://www.githubstatus.com/history, I see that today there were two reported problems with Actions specifically a bit earlier than the PR's timestamp, it seems.

The environments wouldn't affect this because they are applied to jobs in another workflow, and you'd have notifications about the approval requests in your inbox. Besides, workflow definition parsing issues manifest themselves differently — there's a weird error message on the workflow run page with almost zero context on what's broken.

@hynek
Copy link
Member Author

hynek commented Dec 21, 2022

They just wouldn't start – it looked like my problems in my package builder where CI wouldn't run on PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants