Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upENH: forbid delete attr from frozen class #118
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Nov 30, 2016
•
Current coverage is 100% (diff: 100%)@@ master #118 diff @@
====================================
Files 8 8
Lines 502 505 +3
Methods 0 0
Messages 0 0
Branches 110 110
====================================
+ Hits 502 505 +3
Misses 0 0
Partials 0 0
|
This comment has been minimized.
This comment has been minimized.
|
This makes sense. Would you please add a changelog entry? |
This comment has been minimized.
This comment has been minimized.
|
Sorry that took so long. Went for 'change' not 'API break'. |
This comment has been minimized.
This comment has been minimized.
|
Thanks! I’m fixed it myself but next time use semantic line feeds please. :) |
tacaswell
deleted the
tacaswell:enh_nodel_when_frozen
branch
Dec 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tacaswell commentedNov 30, 2016
Raise FrozenInstanceError when trying to delete an attribute from
a frozen class.
On non-frozen classes
delresults in un-shadowing theattr.ibobject which is a bit surprising.