Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: forbid delete attr from frozen class #118

Merged
merged 2 commits into from Dec 14, 2016

Conversation

@tacaswell
Copy link
Contributor

@tacaswell tacaswell commented Nov 30, 2016

Raise FrozenInstanceError when trying to delete an attribute from
a frozen class.

On non-frozen classes del results in un-shadowing the attr.ib object which is a bit surprising.

Raise FrozenInstanceError when trying to delete an attribute from
a frozen class.
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 30, 2016

Current coverage is 100% (diff: 100%)

Merging #118 into master will not change coverage

@@           master   #118   diff @@
====================================
  Files           8      8          
  Lines         502    505     +3   
  Methods         0      0          
  Messages        0      0          
  Branches      110    110          
====================================
+ Hits          502    505     +3   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 6771640...3e512af

@hynek
Copy link
Member

@hynek hynek commented Dec 4, 2016

This makes sense. Would you please add a changelog entry?

@tacaswell
Copy link
Contributor Author

@tacaswell tacaswell commented Dec 14, 2016

Sorry that took so long. Went for 'change' not 'API break'.

@hynek hynek merged commit 72743d2 into python-attrs:master Dec 14, 2016
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0.00%) compared to 6771640
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hynek
Copy link
Member

@hynek hynek commented Dec 14, 2016

Thanks! I’m fixed it myself but next time use semantic line feeds please. :)

@tacaswell tacaswell deleted the tacaswell:enh_nodel_when_frozen branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants