New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post init hook not being called if validators are disabled (#129) #130

Merged
merged 6 commits into from Jan 6, 2017

Conversation

Projects
None yet
3 participants
@p-himik
Contributor

p-himik commented Jan 5, 2017

No description provided.

@codecov-io

This comment has been minimized.

codecov-io commented Jan 5, 2017

Current coverage is 100% (diff: 100%)

Merging #130 into master will not change coverage

@@           master   #130   diff @@
====================================
  Files           8      8          
  Lines         505    504     -1   
  Methods         0      0          
  Messages        0      0          
  Branches      110    110          
====================================
- Hits          505    504     -1   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update cfb7a31...3925d63

@hynek

This comment has been minimized.

Member

hynek commented Jan 5, 2017

Well that sure is an oops! :) Could you add tests and a changelog entry please?

@hynek

Almost there, thank you!

a.name))
names_for_globals[val_name] = a.validator
names_for_globals[attr_name] = a
lines.append("if _config._run_validators:")

This comment has been minimized.

@hynek

hynek Jan 6, 2017

Member

Please use the more explicit if _config._run_validators is True:.

@@ -26,6 +26,8 @@ Changes:
- Raise ``FrozenInstanceError`` when trying to delete an attribute from a frozen class.
`#118 <https://github.com/hynek/attrs/pull/118>`_
- Fix __attrs_post_init__ not being run when the validation is disabled.

This comment has been minimized.

@hynek

hynek Jan 6, 2017

Member

Please put __attrs_post_init__ in double backticks to make it code (like FrozenInstanceError above).

@hynek hynek modified the milestone: 17.0 Jan 6, 2017

@hynek

hynek approved these changes Jan 6, 2017

@hynek hynek merged commit 1481227 into python-attrs:master Jan 6, 2017

3 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0.00%) compared to cfb7a31
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hynek

This comment has been minimized.

Member

hynek commented Jan 6, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment