Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post init hook not being called if validators are disabled (#129) #130

merged 6 commits into from Jan 6, 2017


Copy link

@p-himik p-himik commented Jan 5, 2017

No description provided.

Copy link

codecov-io commented Jan 5, 2017

Current coverage is 100% (diff: 100%)

Merging #130 into master will not change coverage

@@           master   #130   diff @@
  Files           8      8          
  Lines         505    504     -1   
  Methods         0      0          
  Messages        0      0          
  Branches      110    110          
- Hits          505    504     -1   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update cfb7a31...3925d63

Copy link

hynek commented Jan 5, 2017

Well that sure is an oops! :) Could you add tests and a changelog entry please?

Copy link

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, thank you!
names_for_globals[val_name] = a.validator
names_for_globals[attr_name] = a
lines.append("if _config._run_validators:")

This comment was marked as spam.

@@ -26,6 +26,8 @@ Changes:

- Raise ``FrozenInstanceError`` when trying to delete an attribute from a frozen class.
`#118 <>`_
- Fix __attrs_post_init__ not being run when the validation is disabled.

This comment was marked as spam.

@hynek hynek modified the milestone: 17.0 Jan 6, 2017
@hynek hynek merged commit 1481227 into python-attrs:master Jan 6, 2017
Copy link

hynek commented Jan 6, 2017


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants