New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix post init hook not being called if validators are disabled (#129) #130
Conversation
Current coverage is 100% (diff: 100%)@@ master #130 diff @@
====================================
Files 8 8
Lines 505 504 -1
Methods 0 0
Messages 0 0
Branches 110 110
====================================
- Hits 505 504 -1
Misses 0 0
Partials 0 0
|
Well that sure is an oops! :) Could you add tests and a changelog entry please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, thank you!
a.name)) | ||
names_for_globals[val_name] = a.validator | ||
names_for_globals[attr_name] = a | ||
lines.append("if _config._run_validators:") |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -26,6 +26,8 @@ Changes: | |||
|
|||
- Raise ``FrozenInstanceError`` when trying to delete an attribute from a frozen class. | |||
`#118 <https://github.com/hynek/attrs/pull/118>`_ | |||
- Fix __attrs_post_init__ not being run when the validation is disabled. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Thanks! |
No description provided.