Fix post init hook not being called if validators are disabled (#129) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #130 diff @@
====================================
Files 8 8
Lines 505 504 -1
Methods 0 0
Messages 0 0
Branches 110 110
====================================
- Hits 505 504 -1
Misses 0 0
Partials 0 0
|
|
Well that sure is an oops! :) Could you add tests and a changelog entry please? |
hynek
requested changes
Jan 6, 2017
| a.name)) | ||
| names_for_globals[val_name] = a.validator | ||
| names_for_globals[attr_name] = a | ||
| lines.append("if _config._run_validators:") |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -26,6 +26,8 @@ Changes: | |||
|
|
|||
| - Raise ``FrozenInstanceError`` when trying to delete an attribute from a frozen class. | |||
| `#118 <https://github.com/hynek/attrs/pull/118>`_ | |||
| - Fix __attrs_post_init__ not being run when the validation is disabled. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
hynek
approved these changes
Jan 6, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.