/attrs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolve and docs. #135

Merged
merged 5 commits into from Jan 21, 2017

Conversation

Reviewers

@hynek hynek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Tinche @codecov-io @hynek
@Tinche
Member

Tinche commented Jan 18, 2017

✨

Tinche added some commits Jan 18, 2017

@Tinche
Evolve and docs.
Loading status checks…
4dbd8fa
@Tinche
Tests now import from attr. 
Fix attr imports.
Fix flake8.
Loading status checks…
d277c92
@codecov-io

This comment has been minimized.

Sign in to view

codecov-io commented Jan 18, 2017 •
edited

Current coverage is 100% (diff: 100%)

Merging #135 into master will not change coverage

@@           master   #135   diff @@
====================================
  Files           8      8          
  Lines         504    522    +18   
  Methods         0      0          
  Messages        0      0          
  Branches      110    114     +4   
====================================
+ Hits          504    522    +18   
  Misses          0      0          
  Partials        0      0

Powered by Codecov. Last update 1481227...d3d4f55
@Tinche
Travis: add CPython 3.6.
Loading status checks…
e4589a3

@Tinche Tinche force-pushed the Tinche:feature/evolve branch from e4ef703 to e4589a3 Jan 18, 2017

@hynek

hynek requested changes Jan 19, 2017
View changes

src/attr/_funcs.py
:raise attr.exceptions.AttrsAttributeNotFoundError: If *attr_name* couldn't
be found on *cls*.
:raise attr.exceptions.NotAnAttrsClassError: If *cls* is not an ``attrs``
class.

This comment has been minimized.

Sign in to view
Copy link
@hynek

hynek Jan 19, 2017

Member

This needs a .. versionadded::.

This comment has been minimized.

Sign in to view
Copy link
@hynek

hynek Jan 19, 2017

Member

Also we have to add an .. deprecated:: to assoc!
CHANGELOG.rst Outdated
@@ -8,6 +8,15 @@ The third digit is only for regressions.
16.4.0 (UNRELEASED)

This comment has been minimized.

Sign in to view
Copy link
@hynek

hynek Jan 19, 2017

Member

This should be changed. :)

This comment has been minimized.

Sign in to view
Copy link
@hynek

hynek Jan 20, 2017

Member

(make it 17.1.0 pls, I’ve stopped doing .0.0 releases this year)

@Tinche Tinche referenced this pull request Jan 20, 2017

Closed

Validating, __init__-based assoc. #124

@Tinche

This comment has been minimized.

Sign in to view
Member

Tinche commented Jan 20, 2017

Sure thing, the changes will be done tonight.
@Tinche
Doc updates.
Loading status checks…
d3d4f55
@Tinche

This comment has been minimized.

Sign in to view
Member

Tinche commented Jan 20, 2017

Done!
@hynek

hynek approved these changes Jan 21, 2017
View changes

@hynek hynek merged commit 0d3cf3f into python-attrs:master Jan 21, 2017
3 checks passed

3 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0.00%) compared to 1481227
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hynek

This comment has been minimized.

Sign in to view
Member

hynek commented Jan 21, 2017

Awesome, thanks!

@exarkun exarkun referenced this pull request Feb 4, 2017

Closed

Add a helper API for assoc + validate #116

@manishtomar manishtomar referenced this pull request Feb 5, 2017

Open

Simple way to make individual attributes immutable? #133

@hynek hynek referenced this pull request Mar 23, 2017

Closed

assoc bypasses validators ? #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment