Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolve and docs. #135

Merged
merged 5 commits into from Jan 21, 2017
Merged

Evolve and docs. #135

merged 5 commits into from Jan 21, 2017

Conversation

@Tinche
Copy link
Member

@Tinche Tinche commented Jan 18, 2017

Tinche added 2 commits Jan 18, 2017
Fix attr imports.
Fix flake8.
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 18, 2017

Current coverage is 100% (diff: 100%)

Merging #135 into master will not change coverage

@@           master   #135   diff @@
====================================
  Files           8      8          
  Lines         504    522    +18   
  Methods         0      0          
  Messages        0      0          
  Branches      110    114     +4   
====================================
+ Hits          504    522    +18   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 1481227...d3d4f55

@Tinche Tinche force-pushed the Tinche:feature/evolve branch from e4ef703 to e4589a3 Jan 18, 2017
:raise attr.exceptions.AttrsAttributeNotFoundError: If *attr_name* couldn't
be found on *cls*.
:raise attr.exceptions.NotAnAttrsClassError: If *cls* is not an ``attrs``
class.

This comment has been minimized.

This comment has been minimized.

@hynek

hynek Jan 19, 2017
Member

Also we have to add an .. deprecated:: to assoc!

@@ -8,6 +8,15 @@ The third digit is only for regressions.
16.4.0 (UNRELEASED)

This comment has been minimized.

@hynek

hynek Jan 19, 2017
Member

This should be changed. :)

This comment has been minimized.

@hynek

hynek Jan 20, 2017
Member

(make it 17.1.0 pls, I’ve stopped doing .0.0 releases this year)

@Tinche
Copy link
Member Author

@Tinche Tinche commented Jan 20, 2017

Sure thing, the changes will be done tonight.

@Tinche
Copy link
Member Author

@Tinche Tinche commented Jan 20, 2017

Done!

@hynek
hynek approved these changes Jan 21, 2017
@hynek hynek merged commit 0d3cf3f into python-attrs:master Jan 21, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0.00%) compared to 1481227
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hynek
Copy link
Member

@hynek hynek commented Jan 21, 2017

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants